The committers listed above are authorized under a signed CLA.

• ✅ login: rolf-moz / name: Rolf Rando (71bb5fa, c184309, 64336af)

Welcome @rolf-moz!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rolf-moz
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

For now the python.sh in the gen project (that auto-generates the full client) should be updated to use 7.1.0. Example:
OPENAPI_GENERATOR_COMMIT="${OPENAPI_GENERATOR_COMMIT:-v7.1.0}"

The version is the gen project is actually not honored. This client overrides the value here.

The change looks good to me. Should we wait for this project to be upgrade to OpenAPI 7.1.0+ first?

@roycaihw
Actually several changes I made are fixes for the OpenAPI 7.1 gen compatibility. One thing I could do is a separate PR for the OpenAPI 7.1.0 support first, and then redo this pr once that gets approved.

PR needs rebase.

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@roycaihw I just wanted to follow up as I think this PR is important. Is it good to merge as-is or would you like to split it up between the adding of OpenAPI 7.1.0 support and the actual upgrade?

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

/remove-lifecycle rotten

I'm are using ansible k8s to connect to a cluster but we need to be able to connect over socks5, If I understand the stacktrace and the discussion in this PR, this contains the stuff I am looking for. :)

urllib3.exceptions.ProxySchemeUnknown: Proxy URL had unsupported scheme socks5, should use http:// or https://

Anything I can do to help here? @roycaihw @rolf-moz

@PhroZenOne yes if you want to rebase you can. I might have time later this week too.

I'm not up to date... is kubernetes client using 7.x openapi generator yet?

If you'd like to try a built library with this support you can use https://github.com/rolf-moz/kubernetes-client-python/tree/feat/add-proxy-support-gen and let me know how it works for you.

@rolf-moz Did a rebase, PR here: #2255 Please have a look.

If you want to update your PR with this I can close mine so we keep this in one place.

Hm, there are API changes with the newer kubernetes API that breaks when testing so my branch will not work:

     File .../kubernetes/dynamic/client.py", line 273, in request
    api_response = self.client.call_api(
TypeError: ApiClient.call_api() got multiple values for argument 'body'

I dont have more time to spend on this right now I'm afraid so for now I will give up. I might have more time next month to look at it.

Made some changes to client.py to make it work again for my use case, but I have no idea if this is a good solution: PhroZenOne@97c36c3

@PhroZenOne @roycaihw Ok looks like this branch is getting some use. Let me see if I can update this PR later today to be up to date with main

Would be really nice if this pull request would be merged would also help with:
#2183

Made pull request for proxy_url before, but it got ignored. But it also include some tests. You could use that if you want.
https://github.com/kubernetes-client/python/pull/2182/files